FrankChen021 commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3813156083
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -736,6 +734,7 @@ public void run()
.builder()
.withDataSourcesSnapshot(dataSourcesSnapshot)
.withDynamicConfigs(metadataManager.configs().getCurrentDynamicConfig())
+
.withRetentionRulesSnapshot(metadataManager.rules().getRulesSnapshot())
Review Comment:
[P1] Rules and config snapshots are not atomic
Dynamic config is read immediately before rules. An update between these
reads can pair alias-based rules with the old alias map; the assigner treats
the alias as invalid and may queue drops for all existing physical replicas.
Capture or validate a coherent config and rules pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
