capistrant commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3814065940
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -736,6 +734,7 @@ public void run()
.builder()
.withDataSourcesSnapshot(dataSourcesSnapshot)
.withDynamicConfigs(metadataManager.configs().getCurrentDynamicConfig())
+
.withRetentionRulesSnapshot(metadataManager.rules().getRulesSnapshot())
Review Comment:
I don't think this is worth it. I wonder if grabbing the rules first and
then the dynamic config in the code can make it good enough. Then in the alias
ops docs we can re-iterate that you should be making alias changes before you
make rules changes that involve those aliases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
