FrankChen021 commented on code in PR #20061:
URL: https://github.com/apache/druid/pull/20061#discussion_r3813157544
##########
server/src/test/java/org/apache/druid/rpc/ServiceClientImplTest.java:
##########
@@ -75,24 +69,21 @@ public class ServiceClientImplTest
private ScheduledExecutorService exec;
- @Rule
- public MockitoRule mockitoRule =
MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS);
-
- @Mock
private HttpClient httpClient;
- @Mock
private ServiceLocator serviceLocator;
private ServiceClient serviceClient;
- @Before
+ @BeforeEach
public void setUp()
{
+ httpClient = Mockito.mock(HttpClient.class);
Review Comment:
[P2] Strict Mockito stubbing was dropped
The migration removes Strictness.STRICT_STUBS without a JUnit 5 replacement,
so unused or mismatched stubs no longer fail tests. The same regression occurs
in SpecificTaskServiceLocatorTest.java. Restore equivalent strict Mockito
configuration so test signals are preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
