FrankChen021 opened a new pull request, #20061:
URL: https://github.com/apache/druid/pull/20061

   ## Summary
   
   - Migrate the PR3-owned server tests for Curator, discovery, messages, RPC, 
general initialization, and segment root/handoff/realtime coverage to JUnit 5.
   - Preserve timeout and exception behavior, use explicit Jupiter assertions, 
and replace JUnit 4 temporary folders with `TemporaryFolderExtension` where 
needed.
   - Keep `server/pom.xml` and shared helpers unchanged; use core Mockito mocks 
because the server module does not provide `mockito-junit-jupiter`, and add 
only a local adapter for the inherited JUnit 4 `JsonConfigTesterBase` lifecycle.
   
   Part of #13948
   
   ## Validation
   
   - `mvn -ntp -pl server -am test-compile -Dweb.console.skip=true -T1C 
-Pskip-static-checks` — PASS.
   - Focused Curator/discovery/messages/RPC/general-initialization suites — 
PASS.
   - Focused segment root/handoff/realtime suites — PASS, 126 tests.
   - `mvn -ntp -pl server -DskipTests -Dweb.console.skip=true checkstyle:check 
spotbugs:check` — PASS; 0 Checkstyle violations, 0 SpotBugs bugs.
   - `git diff --check offical/master` — PASS; no static imports added.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to