FrankChen021 commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3830376721
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -736,6 +734,7 @@ public void run()
.builder()
.withDataSourcesSnapshot(dataSourcesSnapshot)
.withDynamicConfigs(metadataManager.configs().getCurrentDynamicConfig())
+
.withRetentionRulesSnapshot(metadataManager.rules().getRulesSnapshot())
Review Comment:
[P1] Dynamic config and rules are not snapshotted atomically
The coordinator run reads the dynamic config and retention rules
independently. An update between these reads can pair an old alias map with new
rules (or the reverse); the assigner can then treat an alias as unresolved and
schedule drops for existing replicas. Capture and validate both versions
atomically, or retry when they do not come from the same configuration
snapshot, before making load/drop decisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
