capistrant commented on code in PR #20063: URL: https://github.com/apache/druid/pull/20063#discussion_r3839394187
########## server/src/main/java/org/apache/druid/server/coordinator/rules/RetentionRulesSnapshot.java: ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.coordinator.rules; + +import com.google.common.collect.Maps; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; + +/** + * Immutable snapshot of the retention rules of every datasource. + */ +public class RetentionRulesSnapshot +{ + /** + * Conventional value of {@code druid.manager.rules.defaultRule}, used only by + * {@link #withClusterDefaults}. Real snapshots take the configured name from their caller, + * as an operator may have changed it. + */ + private static final String DEFAULT_DATASOURCE_NAME = "_default"; + + // The default datasource name is immaterial when there are no rules to look it up in + private static final RetentionRulesSnapshot EMPTY = new RetentionRulesSnapshot(Map.of(), ""); + + /** + * Rules of each datasource exactly as configured, i.e. no entry has {@link #clusterDefaultRules} + * appended to it. The cluster defaults are still present as the entry for the default datasource + * ({@code druid.manager.rules.defaultRule}), which is where {@link #clusterDefaultRules} comes from. + */ + private final Map<String, List<Rule>> datasourceToRules; + /** + * Override rules of each datasource, already concatenated with {@link #clusterDefaultRules}. + * Contains an entry only for datasources that have override rules and are not the default + * datasource itself, so that everything else can share the {@link #clusterDefaultRules} instance. + */ + private final Map<String, List<Rule>> datasourceToRulesWithDefault; + private final List<Rule> clusterDefaultRules; + + public static RetentionRulesSnapshot empty() + { + return EMPTY; + } + + /** + * Snapshot in which the given rules are the cluster defaults and no datasource has + * override rules, so that they apply to every datasource. + */ + public static RetentionRulesSnapshot withClusterDefaults(List<Rule> clusterDefaultRules) Review Comment: opted to get rid of this and just send the tests through the constructor path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
