cecemei commented on code in PR #20149:
URL: https://github.com/apache/druid/pull/20149#discussion_r3867557481
##########
processing/src/test/java/org/apache/druid/query/filter/FilterSegmentPrunerTest.java:
##########
@@ -329,6 +331,74 @@ void testPruneNumericIn()
Assertions.assertTrue(pruner.include(seg));
}
+ @Test
+ void testPruneClusterGroupTuples()
+ {
+ final String interval = "2026-01-01T00:00:00Z/2026-01-02T00:00:00Z";
+ final RowSignature clusteringColumns = RowSignature.builder().add("dim1",
ColumnType.STRING).build();
+ final ClusterGroupTuples tuples = new ClusterGroupTuples(
+ clusteringColumns,
+ List.of(List.of("abc"), List.of("xyz"))
+ );
+
+ final DataSegment seg = makeDataSegment(interval, makeRange("dim1", 0,
null, null), tuples);
+
+ final DimFilter matchingFilter = new EqualityFilter("dim1",
ColumnType.STRING, "abc", null);
+ final DimFilter nonMatchingFilter = new EqualityFilter("dim1",
ColumnType.STRING, "foo", null);
+
+ Assertions.assertTrue(new FilterSegmentPruner(matchingFilter, null,
null).include(seg));
+ Assertions.assertFalse(new FilterSegmentPruner(nonMatchingFilter, null,
null).include(seg));
+ }
+
+ @Test
+ void testClusterGroupTuplesSkipsNonStringColumns()
+ {
+ // Numeric columns are skipped for pruning (see druid issue #19408), so
this must not prune.
+ final String interval = "2026-01-01T00:00:00Z/2026-01-02T00:00:00Z";
+ final RowSignature clusteringColumns = RowSignature.builder().add("id",
ColumnType.LONG).build();
+ final ClusterGroupTuples tuples = new
ClusterGroupTuples(clusteringColumns, List.of(List.of(100L), List.of(200L)));
+
+ final DataSegment seg = makeDataSegment(interval, makeRange("dim1", 0,
null, null), tuples);
+ final DimFilter filter = new EqualityFilter("id", ColumnType.LONG, 999L,
null);
+
+ Assertions.assertTrue(new FilterSegmentPruner(filter, null,
null).include(seg));
+ }
+
+ @Test
+ void testPruneClusterGroupTuplesVirtualColumn()
+ {
+ final VirtualColumns clusterVirtualColumns = VirtualColumns.create(
+ new ExpressionVirtualColumn("vdim1", "concat(dim1, 'foo')",
ColumnType.STRING, TestExprMacroTable.INSTANCE)
+ );
+ final RowSignature clusteringColumns = RowSignature.builder().add("vdim1",
ColumnType.STRING).build();
+ final ClusterGroupTuples tuples = new ClusterGroupTuples(
+ clusteringColumns,
+ clusterVirtualColumns,
+ List.of(List.of("abcfoo"), List.of("xyzfoo"))
+ );
+
+ final String interval = "2026-01-01T00:00:00Z/2026-01-02T00:00:00Z";
+ final DataSegment seg = makeDataSegment(interval, makeRange("dim1", 0,
null, null), tuples);
+
+ // same expression, same name
+ VirtualColumns queryVirtualColumns = VirtualColumns.create(
+ new ExpressionVirtualColumn("vdim1", "concat(dim1, 'foo')",
ColumnType.STRING, TestExprMacroTable.INSTANCE)
Review Comment:
we have `testPruneClusterGroupTuples` for testing querying directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
