FrankChen021 commented on PR #20314: URL: https://github.com/apache/druid/pull/20314#issuecomment-5692904985
> @FrankChen021 Nice find on the [performance regression](https://github.com/apache/druid/issues/20326#issuecomment-5664833172) > > Do you think it's still worthwhile to have a planning timeout? I think it still could be valuable in order to prevent heap exhaustion under heavy query load with large in-clauses May be useful as a protection mechansim that queries with long planning time do not overwhelm the system. Since the underlying Calcite problem has been resolved, now I can't figure out under which cases there will be such problem. I think one more important thing is that we need performance regression test for each PR so that we can know and solve any performance regression before it's merge into the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
