zhang-arvin commented on PR #20089:
URL: https://github.com/apache/druid/pull/20089#issuecomment-5778959324
**Correction to my previous comment's test evidence** — I described the test
run too loosely, and the distinction matters if you re-run it.
I wrote "12 tests, 0 failures, 0 errors (2 flakes)". The aggregate line does
say `Tests run: 12, Flakes: 2`, but that number is misleading about where the
two classes landed:
- **`BrokerServerViewTest`** is where the 12 executed tests come from — all
pass. This is the class that actually exercises `BrokerServerView`.
- **`CoordinatorServerViewTest`** reported `Tests run: 0`. Neither of its
two test methods executed: `testSingleServerAddedRemovedSegment` and
`testMultipleServerAddedRemovedSegment` each failed 5/5 retries inside
`setupViews:372`, on `EasyMock.createMock(DirectDruidClientFactory.class)` →
*"Failed to mock class ... with provider DefaultClassInfoProvider"*.
So it is not "2 flakes" — it is one class fully passing and another failing
to **set up at all**.
I want to be precise about attribution, since it is my change under review:
- Commit `75129aa4` touches exactly one file:
`server/src/main/java/org/apache/druid/client/BrokerServerView.java`. No test
file is modified by this PR.
- `CoordinatorServerViewTest` was last changed by **#20031** ("test(server):
migrate first server test batch to JUnit 5"), unrelated to this PR.
- The failure mode is in the mock construction for
`DirectDruidClientFactory`, reached before any of the delay logic under review
executes.
So this looks like pre-existing breakage from the JUnit 5 migration batch
rather than anything this PR introduced — but I have not verified that by
checking out `druid/dev` at the merge-base and running the same class, so treat
it as an inference, not a proven fact. If you want, I can do that check and
post the result; it is a quick run.
Net: the coverage I can vouch for on this PR is `BrokerServerViewTest` (12
tests, 0 failures, 0 errors) plus a clean `mvn -pl server compile`. I am not
claiming `CoordinatorServerViewTest` passes, because in my environment it does
not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
