zhang-arvin commented on PR #20089: URL: https://github.com/apache/druid/pull/20089#issuecomment-5779218931
**I ran the base-commit check I offered, and it settles both questions above — with a stronger result than expected.** Method: a detached `git worktree` at `d28a1a82` (the state before my `75129aa4`), so the PR branch was untouched. Verified the checkout is genuinely pre-change (`grep -c EntryFuture` → `0`). Then `mvn -pl server test -Dtest=CoordinatorServerViewTest`. Result — it does not get as far as running a test: ``` [ERROR] COMPILATION ERROR : [ERROR] BrokerServerView.java:[440,64] 可能尚未初始化变量pendingRemoval [ERROR] (variable pendingRemoval might not have been initialized) [INFO] BUILD FAILURE ``` **The base commit does not compile.** That is exactly the finding from your 2026-08-22 review: > *"The scheduled lambda references `pendingRemoval` while that final local is still being initialized. Java definite-assignment rules reject this with 'variable pendingRemoval might not have been initialized', blocking compilation."* So that P1 was not a style concern — it was a hard build break, and I had only inferred it from a minimal `javac` repro until now. Now it is confirmed against the real build. This also revises what I said in my correction comment above. I attributed `CoordinatorServerViewTest`'s failure to pre-existing breakage from the JUnit 5 migration (#20031) and hedged it as "inference, not proven". The truth is more concrete: **`CoordinatorServerViewTest` cannot run on the base commit at all, because `druid-server` fails to compile.** No mock ever gets constructed. My earlier "2 flakes / EasyMock provider" framing was a symptom of running against a tree where the fix was already present — the underlying baseline was simply broken. Net effect worth noting for the review: `BrokerServerViewTest`'s 12 passing tests only become runnable *after* this fix. On `d28a1a82` there is no passing test run at all, for any class in `druid-server`. I have left the worktree in place; happy to run any further base-vs-head comparison you want — this is a cheap check now that the method is set up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
