maytasm commented on PR #20403: URL: https://github.com/apache/druid/pull/20403#issuecomment-5867941034
@kgyrtkirk The adaptive pool only closes expired or broken idle connections when a later take(key) for the same destination walks past them (ResourcePool.java, takeIdleResource). That lets a destination you still query shrink back to the number of connections its traffic needs. What it doesn't fix (destinations that go away): On master the outer cache still never expires anything. It's built with CacheBuilder.newBuilder().build(...) and has no expireAfterAccess, no removal listener and no invalidate API (ResourcePool.java:68). Once a destination stops being called, such as a finished task or a replaced Historical, nothing calls take() for it again. Its idle connections, with their SSL engines and buffers, stay on the heap until the process restarts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
