FrankChen021 commented on code in PR #18681:
URL: https://github.com/apache/druid/pull/18681#discussion_r4155611877
##########
distribution/bin/tag-missing-milestones.py:
##########
@@ -53,12 +53,19 @@
continue
if pr['milestone'] is None:
print("Tagging Pull Request {} with milestone {}".format(pr_number,
milestone))
- url =
"https://api.github.com/repos/apache/druid/issues/{}".format(pr_number)
- requests.patch(url, json=milestone_json, auth=(github_username,
os.environ["GIT_TOKEN"]))
+ if os.environ.get("DRY_RUN", "true").lower() == "false":
Review Comment:
[P1] Default dry-run disables milestone tagging
**Finding:** A normal invocation now takes the `DRY_RUN` default of `true`,
so every missing milestone is only reported and the GitHub PATCH is skipped.
The release guide still presents this script as the tool that tags missing PRs,
and `find-missing-backports.py` relies on those milestones; following the
documented workflow therefore leaves PRs untagged and can make the later
backport check silently incomplete.
**Suggestion:** Keep the normal invocation mutating (or add an explicit
`--dry-run` opt-in) and document the safe preview mode separately.
##########
distribution/asf-release-process-guide.md:
##########
@@ -559,27 +591,25 @@ Once the Druid community vote passes (or fails), close
the vote with a thread li
##### Subject
```plaintext
-[RESULT][VOTE] Release Apache Druid 0.17.0 [RC3]
+[RESULT][VOTE] Release Apache Druid 37.0.0 [RC2]
```
##### Body
```plaintext
Thanks to everyone who participated in the vote! The results are as follows:
-Clint Wylie: +1 (non-binding)
-Jihoon Son: +1 (binding)
-Furkan KAMACI: +1 (non-binding)
-Julian Hyde: +1 (binding)
-David Lim: +1 (binding)
-Surekha Saharan: +1 (non-binding)
+Lucas Capistrant: +1 (binding)
+Clint Wylie: +1 (binding)
+Cece Mei: +1 (binding)
+The vote has passed with 3 binding +1 votes!
...
```
### Cancelling a vote
-If for any reason during the Druid PMC vote a blocking issue becomes apparent,
a vote should be officially cancelled by sending an email with the following
subject line: `[CANCEL][VOTE] Release Apache Druid 0.17.0 [RC3]` and the
reasons for the cancellation in the body.
+If for any reason during the Druid PMC vote a blocking issue becomes apparent,
a vote should be officially cancelled by sending an email with the following
subject line: `[CANCEL][VOTE] Release Apache Druid 37.0.0 [RC3]` and the
reasons for the cancellation in the body.
Review Comment:
[P3] Cancellation template names the wrong release candidate
**Finding:** The voting and final-release instructions in this same guide
use `druid-37.0.0-rc2`, but the cancellation subject was changed to `37.0.0
[RC3]`. Copying the cancellation template for the documented vote would
identify a different, likely nonexistent candidate and make the release-thread
record inaccurate.
**Suggestion:** Use the same candidate placeholder/version as the vote and
final-release examples, or make the RC number explicitly variable throughout
the template.
##########
distribution/asf-release-process-guide.md:
##########
@@ -362,15 +405,16 @@ $ svn checkout
https://dist.apache.org/repos/dist/dev/druid
Copy the `src` and `bin` artifacts to a folder for the release version and add
it to SVN and publish the artifacts:
```bash
-$ svn add 0.17.0-rc3
+$ cp ../druid-release/distribution/target/apache* ./37.0.0-rc1/.
Review Comment:
[P2] Artifact copy targets a directory that was never created
**Finding:** Immediately after checking out `dist/dev/druid`, the documented
command copies into `./37.0.0-rc1/.`, but no step creates that directory. From
a clean checkout, `cp` fails with a missing-destination error and the release
artifacts are never staged for `svn add`.
**Suggestion:** Create the release-candidate directory before copying, or
use a checkout/copy command that creates the destination explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
