FrankChen021 commented on code in PR #20590:
URL: https://github.com/apache/druid/pull/20590#discussion_r4272917355
##########
.github/dependabot.yml:
##########
@@ -18,15 +18,28 @@ updates:
patterns:
- "org.apache.maven.resolver:*"
ignore:
- # pin ZooKeeper dependencies to 3.5.x
- - dependency-name: "org.apache.zookeeper"
- versions: "[3.6,)"
- # pin Jetty dependencies to 9.4.x
- - dependency-name: "org.eclipse.jetty"
- versions: "[9.5,)"
- # pin Testng dependencies to 7.3.0
- - dependency-name: "org.testng"
- versions: "[7.4.0,)"
+ # zstd-jni 1.5.7-13 and later cannot decode legacy (pre-1.0) zstd frames
in .zst batch input
+ - dependency-name: "com.github.luben:zstd-jni"
+ versions: "[1.5.7-13,)"
Review Comment:
[P2] Open-ended zstd ignore suppresses security fixes
**Finding:** The open-ended versions range prevents Dependabot from
surfacing future zstd-jni security-update PRs at or above 1.5.7-13. The
upstream project already lists 1.5.7-14 as a security fix for 1.5.7-13, but
this rule suppresses that release too.
**Suggestion:** Keep the compatibility constraint but add an explicit manual
security-update tracking path, or make legacy decoding compatible with a
patched zstd-jni release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
