FrankChen021 commented on issue #20525: URL: https://github.com/apache/druid/issues/20525#issuecomment-6361354026
### Not tracked by CodeQL: Jetty `GzipHandler` `org.eclipse.jetty.server.handler.gzip.GzipHandler` is `@Deprecated(since = "12.1.1", forRemoval = true)` and shows up as `javac` removal warnings, but it does not appear in the CodeQL `java/deprecated-call` alerts. CodeQL's `java/deprecated-call` rule seems to flag only calls to deprecated methods, not uses of a deprecated class as a type or with `new`. Usage: `JettyServerInitUtils.wrapWithDefaultGzipHandler` (`server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerInitUtils.java`), called from the Coordinator, Overlord, Broker/Historical, MiddleManager, Router and the test servers. Migration notes: - Replacement is `CompressionHandler` from `org.eclipse.jetty.compression:jetty-compression-server` together with `jetty-compression-gzip`. Both are new dependencies and need `licenses.yaml` entries. - Preserve current behavior: minimum compression size `0`, only `GET`/`POST`, configurable inflate buffer size and compression level (`druid.server.http.inflateBufferSize`, `druid.server.http.compressionLevel`), and request-body inflation. - `wrapWithDefaultGzipHandler` returns `GzipHandler`. Its callers only use the result as a `Handler`. Related: `QueuedThreadPool.getReadyThreads()` (alerts #10965, #10966) can be replaced by `getIdleThreads() + getCurrentReservedThreads()`, which is what the deprecated method returns, so the `jetty/threadPool/ready` metric stays the same. --- Disclosure: This comment was prepared by Claude Code, an Anthropic AI assistant, on behalf of @FrankChen021. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
