glasser commented on issue #7243: stringFirst/stringLast crashes at aggregation 
time
URL: 
https://github.com/apache/incubator-druid/issues/7243#issuecomment-476384529
 
 
   I honestly couldn't figure out what the purpose of the 
`StringFirstFoldingAggregatorFactory` class was.
   
   For a short term fix (to fix the bug, without the refactors you're 
suggesting), is the suggestion that 
`StringFirstFoldingAggregatorFactory.makeAggregateCombiner` should have return 
`this`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to