glasser commented on issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243#issuecomment-476399166 Oh I see. I was getting `makeAggregateCombiner()` and `getCombiningFactory()` confused. So make `StringFirstFoldingAggregatoryFactory.makeAggregateCombiner()` return a new `StringFirstFoldingAggregateCombiner` which acts on pairs. I still don't know where to write tests that prove that I've written the correct classes, though.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
