FrankChen021 commented on code in PR #20708:
URL: https://github.com/apache/druid/pull/20708#discussion_r4370813273
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -576,7 +608,7 @@ CostMetrics collectMetrics()
final int partitionCount = supervisor.getPartitionCount();
final Map<String, Map<String, Object>> taskStats = supervisor.getStats();
- final double movingAvgRate = extractMovingAverage(taskStats);
+ final double movingAvgRate = extractRunningAvgProcessingRate(taskStats);
Review Comment:
Thanks, but the compatibility finding is still applicable. Druid's
rolling-update guidance explicitly allows upgrading the Overlord before any
Middle Manager when autoscaling-based replacement is used, and old workers are
gracefully terminated only as their tasks finish. During that window, the new
Overlord can collect legacy task reports containing only pollIdleRatio and
movingAverages, so the new-only extraction can return -1 or average only the
new tasks. Please retain the legacy fallback. For this reply-only follow-up, I
reviewed 1 of the PR's 6 changed files, focusing on CostBasedAutoScaler and the
report path.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
