leventov commented on issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243#issuecomment-476387901 > For a short term fix (to fix the bug, without the refactors you're suggesting), is the suggestion that StringFirstFoldingAggregatorFactory.makeAggregateCombiner should have return this? It seems to me that no, you cannot return `this`. Folding aggregators are uniquely different from the simple aggregators. You can make simple aggregators kinda accept both (AFAIR some complex aggregators work this way), but it will make the basic aggregation less efficient. As a short term fix you can override `makeAggregateCombiner()` in Folding aggregators properly, shouldn't be a very big deal (still without refactoring I'm suggesting.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
