leventov commented on issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243#issuecomment-476417234 I cannot think of a better place than `StringFirstFoldingAggregatoryFactoryTest`, and calling methods like `makeAggregateCombiner()` manually and applying values manually. Admittedly, these interfaces are hard to test. It needs work. I've opened #7340 about this. For your patch, it's not *obligatory* to add such tests, at least because many other aggregator factories currently don't have such tests either.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
