kgyrtkirk commented on code in PR #20718:
URL: https://github.com/apache/druid/pull/20718#discussion_r4374833852
##########
.github/workflows/worker.yml:
##########
@@ -72,20 +79,43 @@ jobs:
java-version: ${{ inputs.jdk }}
cache: 'maven'
+ - name: Determine Apache parent POM version
+ id: apache-parent
+ run: |
+ set -eu
+ version=$(sed -n
'/<parent>/,/<\/parent>/s:.*<version>\(.*\)</version>.*:\1:p' pom.xml | head -1)
+ if [ -z "$version" ]; then
+ echo "::error ::Could not read the parent POM version from pom.xml"
+ exit 1
+ fi
+ echo "version=$version" >> "$GITHUB_OUTPUT"
+
+ # The setup-java Maven cache is keyed on every pom.xml, so it misses
whenever a pom changes and the
+ # parent POM must then come from Central. Keep the parent POM in its own
small cache so it is always local.
+ - name: Cache Apache parent POM
+ uses: actions/cache@v6
+ with:
+ path: ~/.m2/repository/org/apache/apache/${{
steps.apache-parent.outputs.version }}
+ key: maven-apache-parent-${{ steps.apache-parent.outputs.version }}
+
# Keep parent-POM resolution separate and before the worker script so
transient
# Maven Central failures are retried before job-specific build or test
work starts.
+ # Maven Resolver already retries 429/5xx (see MAVEN_ARGS); this loop
also covers "not found"
+ # answers and dropped connections, which the resolver does not retry.
- name: Resolve Apache parent POM
run: |
set -eu
+ delay=10
for attempt in 1 2 3; do
Review Comment:
what is this? already 3 attempts?
seems like we are on a sinking ship already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
