capistrant opened a new pull request, #20778: URL: https://github.com/apache/druid/pull/20778
### Description Targeted fix for a bug in allowing msq-dart/msq-task queries through validation with a right/full broadcast join when the context join algorithm was non-broadcast but a join hint pushed the query to plan to broadcast for at least one join. right/full joins are not supported by MSQ according to code and [docs](https://druid.apache.org/docs/latest/multi-stage-query/reference#broadcast). this closes a loop hole I found when working on unrelated code. Perhaps there is more substantial consideration to be given here for join planning and validation. I briefly considered a final just in time check during validation on the controller as a safety net, but it wasn't clear if that would be clean so I didn't pursue it very far at all. Aside -- are join hints in the apache docs? I didnt find them. #### Release note Queries using `broadcast` join hint for right/full joins on queries running on msq-dart or msq-task engines are now rejected. <hr> ##### Key changed/added classes in this PR * `QueryValidations` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [ ] been self-reviewed. - [ ] a release note entry in the PR description. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
