FrankChen021 commented on code in PR #20814:
URL: https://github.com/apache/druid/pull/20814#discussion_r4442509217
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/k8s/K3sClusterResource.java:
##########
@@ -355,7 +387,218 @@ private void waitUntilPodIsReady(PodResource pod)
);
}
catch (KubernetesClientTimeoutException e) {
- throw new ISE("Timed out waiting for pod[%s] to be ready",
pod.get().getMetadata().getName());
+ dumpPodLogs(DRUID_NAMESPACE);
Review Comment:
[P2] Dump timeout logs from the actual namespace
**Finding:** `waitUntilPodIsReady` is also used by
`K3sClusterWithOperatorResource` while waiting in `druid-operator-system`, but
this hard-coded argument lists pods only from `druid`. When an operator pod
times out, its full logs are therefore absent from the CI artifact, leaving the
new failure diagnostics incomplete for that supported path.
**Suggestion:** Pass the namespace being waited on, or derive it from the
timed-out pod, when calling `dumpPodLogs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
