jihoonson commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-476914630 @leventov I agree that `is_active` is not the best term. That actually represents that the segment is supposed to be loaded or not, so that users can understand why some segments are not loaded, or notice that some segments should be loaded but they are not. Do you have a better suggestion? Regarding `is_overshadowed`, I don't think it's a good idea to restrict its definition to such a narrow scope because it's being used in various situations in our code base as well as documents. So, for example, the coordinator searches for segments which are loaded by historicals and overshadowed by published segments to tidy up old segments. Brokers searches for non-overshadowed segments among available segments in tasks or historicals for query execution. Even in historicals, they searches for non-overshadowed segments among the segments loaded in itself (note that two segments of different versions but for the same interval can exist in the same historical before the coordinator cleans up the old one). I don't think it's worth to define different terms for various cases. It would make things more complicated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
