gianm commented on code in PR #20825:
URL: https://github.com/apache/druid/pull/20825#discussion_r4459099364


##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/guice/DartWorkerConfig.java:
##########
@@ -59,6 +61,18 @@ public class DartWorkerConfig
   @Nullable
   private Integer segmentLoadAheadCount = null;
 
+  /**
+   * How long a controller can go without contacting this worker before {@link 
DartWorkerRunner} considers it gone.
+   */
+  @JsonProperty("controllerTimeout")
+  private Period controllerTimeout = Period.minutes(3);
+
+  /**
+   * How long a query can be missing from a controller's syncs before {@link 
DartWorkerRunner} cancels it.
+   */
+  @JsonProperty("syncGracePeriod")
+  private Period syncGracePeriod = Period.seconds(30);

Review Comment:
   I renamed it to `syncTimeout`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to