kfaraz commented on code in PR #20825:
URL: https://github.com/apache/druid/pull/20825#discussion_r4458613509
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/DartControllerRegistry.java:
##########
@@ -123,6 +132,18 @@ public void stop()
if (cleanupExec != null) {
cleanupExec.shutdown();
}
+
+ final List<ControllerHolder> holders = new
ArrayList<>(controllerMap.values());
+ if (!holders.isEmpty()) {
+ log.info("Canceling [%d] queries that are still running.",
holders.size());
+
+ for (final ControllerHolder holder : holders) {
+ holder.cancel(CancellationReason.TASK_SHUTDOWN, null);
Review Comment:
Yes, this seems like a valid concern.
#20313 had tried to address the problem of unreachable historicals but it
wasn't an effective fix.
We will need a separate fix to not get stuck trying to contact unreachable
workers, but I don't think it should be a part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
