pdeva edited a comment on issue #7486: regression: quantilesDoublesSketch returns null instead of empty array URL: https://github.com/apache/incubator-druid/issues/7486#issuecomment-485013520 >In your example query you wanted four quantile values for ranks 0.5, 0.9, 0.95 and 0.99. How would you process the result? What if it is an empty array, not an array with four values you would expect? as i mentioned, the code to handle arrays gracefully handles empty arrays, whether its charting libraries or our own code. but `null` throws a wrench into everything.. Even in the code you pointed out: > `return sketch.getQuantiles(fractions);` as you yourself point out, this now has to be special cased to handle null, whereas it worked fine with empty arrays previously. returning an empty array instead would allow all existing code to continue working
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
