gianm commented on issue #7574: making VirtualColumn more powerful URL: https://github.com/apache/incubator-druid/issues/7574#issuecomment-487802026 @himanshug, 1. I'm wondering if it's useful to add capabilities that tell callers whether methods like `makeDimensionSelector(String columnName, ColumnSelector columnSelector, ReadableOffset offset)` are going to work before calling them. It might be nice if it lets callers branch off into different ways of handling things before they actually create selectors. If this change is made, then these methods could be made non-nullable and the default impls could throw unsupported operation exceptions. 2. For the test plan, assuming you are planning on adding unit tests that exercise the new methods, that sounds good to me. 3. Would you be interested in open-sourcing your nested-data-structure complex column implementation? It sounds like something that could be quite generally useful. 4. Would you need to propose any changes to the `VirtualColumns` class as well?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
