gianm commented on issue #7574: making VirtualColumn more powerful
URL: 
https://github.com/apache/incubator-druid/issues/7574#issuecomment-488134076
 
 
   @himanshug,
   
   1) To be clear, I wasn't saying 'definitely do it', just wondering if it's a 
good idea. I was hoping you could tell me if it seems like a good idea to you 
based on your work so far.
   
   2/3) The main intent behind asking if you're interested in open-sourcing the 
implementation is because an indexed nested data column sounds like a super 
useful thing. If you don't end up contributing yours I think it would still be 
best to have some sort of implementation, even if it lives in the /test/ tree 
and is solely for unit test purposes. If only because that way, even if the 
functionality works today, it won't accidentally break later when someone 
refactors some code and doesn't notice that it broke these new methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to