leventov commented on a change in pull request #7595: Optimize overshadowed
segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r282158038
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
##########
@@ -744,6 +757,32 @@ public DataSegment map(int index, ResultSet r,
StatementContext ctx) throws SQLE
// Replace "dataSources" atomically.
dataSources = newDataSources;
+ overshadowedSegments =
ImmutableSet.copyOf(determineOvershadowedSegments(segments));
+ }
+
+ /**
+ * This method builds a timeline from given segments and finds the
overshadowed segments
+ *
+ * @return set of overshadowed segments
+ */
+ private Set<DataSegment> determineOvershadowedSegments(Iterable<DataSegment>
segments)
Review comment:
Doesn't need to be set, you copy into another Set anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
