jihoonson commented on a change in pull request #7611: Add plain text
README.txt, use relative link from README.md to build.md
URL: https://github.com/apache/incubator-druid/pull/7611#discussion_r282626534
##########
File path: distribution/src/assembly/source-assembly.xml
##########
@@ -47,6 +47,7 @@
<exclude>.gitignore</exclude>
<exclude>.dockerignore</exclude>
<exclude>.travis.yml</exclude>
+ <exclude>README.md</exclude>
Review comment:
Hmm. I mean, is it better to add both, so that ppl can still choose whatever
they prefer? The markdown file is not best for terminal users, but some
terminal tools still support markdown syntax. For example, even `vi` shows
comments, texts, and titles with different colors. It looks easier to read to
me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
