vogievetsky commented on a change in pull request #7703: Web console: add log
tailing to task log view
URL: https://github.com/apache/incubator-druid/pull/7703#discussion_r285784062
##########
File path: web-console/src/components/show-log.tsx
##########
@@ -71,12 +73,39 @@ export class ShowLog extends React.Component<ShowLogProps,
ShowLogState> {
}
}
+ private tail() {
+ this.getLogInfo().then(() => {
+ if (this.state.tail) {
+ if (this.log.current) {
+ this.log.current.scrollTo(0, this.log.current.scrollHeight); }
+ setTimeout(function() {
+ this.tail();
+ }.bind(this), 2000);
+ }
+ });
Review comment:
oh my the indentation in this function is all messed up also you do not need
to do `.bind(this)` you can just use `() => {}` syntax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
