clintropolis commented on issue #7731: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494957996 >This would fix the problem for extensions not in druid codebase and also one less thing to worry by future aggregator factory writers. I considered that as well, but didn't initially make the change because it would be taking a stronger position to mean that aggregators are not allowed to transform a null into a different value when finalizing a computation. My initial commit failed tests because I didn't realize that the cardinality/hyperunique aggregator were doing this in the `HyperUniquesAggregatorFactory.estimateCardinality` method, because it wasn't marked as nullable so I assumed it was non-null.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
