clintropolis commented on issue #7731: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494988305 I think cardinality/hyperunique behavior also raises another thing to consider, is that maybe we should try to make this behavior consistent for the same types of aggregators, like for example `HllSketchAggregatorFactory.finalizeComputation` should maybe return 0 instead of null when faced with null to behave the same way. Reasoning this through is maybe a bit more involved than fixing the null pointer exceptions, so it might be better suited to a follow-up PR to try to make similar aggregators behave consistently?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
