leventov commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r287344872
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
##########
@@ -136,33 +213,70 @@ public SQLMetadataSegmentManager(
)
{
this.jsonMapper = jsonMapper;
- this.config = config;
+ this.periodicPollDelay =
config.get().getPollDuration().toStandardDuration();
this.dbTables = dbTables;
this.connector = connector;
}
- @Override
+ /**
+ * Don't confuse this method with {@link #startPollingDatabasePeriodically}.
This is a lifecycle starting method to
Review comment:
I'm not sure it's called just once by our lifecycling logic. Most of
`@LifecycleStart` methods in the project are idempotent. I think that's better
than if they were throwing exceptions on non-first calls.
However, this method was lacking an idempotency check, I've added it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
