gianm commented on issue #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#issuecomment-496026601 The test error looks potentially legitimate; please check this test and any others referenced in the Travis CI report: ``` org.apache.druid.indexing.firehose.IngestSegmentFirehoseFactoryTest.testGetUniqueDimensionsAndMetrics[DimNames[dims]MetricNames[metrics]ParserDimNames[dims]WrapInCombining[false]](org.apache.druid.indexing.firehose.IngestSegmentFirehoseFactoryTest) Run 1: IngestSegmentFirehoseFactoryTest.testGetUniqueDimensionsAndMetrics:539 expected:<[met9, met10, met11, met12, met13, met8, met7, met6, met5, met4, met3, met2, met1, met0]> but was:<[met9, met10, met11, met12, met13, met8, null, null, null, null, met7, null, null, null]> ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
