surekhasaharan commented on a change in pull request #7653: Refactor 
SQLMetadataSegmentManager; Change contract of REST methods in 
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r287931169
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
 ##########
 @@ -713,6 +1021,8 @@ public DataSegment map(int index, ResultSet r, 
StatementContext ctx) throws SQLE
                         }
                         catch (IOException e) {
                           log.makeAlert(e, "Failed to read segment from 
db.").emit();
+                          // If one entry is database is corrupted, doPoll() 
should continue to work overall. See
 
 Review comment:
   nit: If one entry "is" -> "in" database ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to