jon-wei commented on a change in pull request #7595: Optimize overshadowed
segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288771515
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorRuleRunner.java
##########
@@ -84,8 +85,10 @@ public DruidCoordinatorRuntimeParams
run(DruidCoordinatorRuntimeParams params)
// find available segments which are not overshadowed by other segments in
DB
// only those would need to be loaded/dropped
// anything overshadowed by served segments is dropped automatically by
DruidCoordinatorCleanupOvershadowed
- final Set<DataSegment> overshadowed = ImmutableDruidDataSource
- .determineOvershadowedSegments(params.getAvailableSegments());
+ // If metadata store hasn't been polled yet, use empty overshadowed list
+ final Set<SegmentId> overshadowed = Optional
+
.ofNullable(coordinator.getMetadataSegmentManager().getOvershadowedSegments())
Review comment:
`DruidCoordinator` and its helpers such as
`DruidCoordinatorSegmentInfoLoader` should fetch the current
DatasourcesSnapshot from `MetadataSegmentManager` at the start of the
coordinator loop and then operate on that snapshot exclusively in the rest of
the coordinator loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
