jon-wei commented on a change in pull request #7595: Optimize overshadowed
segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288369870
##########
File path:
core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java
##########
@@ -21,16 +21,23 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonUnwrapped;
/**
* DataSegment object plus the overshadowed status for the segment. An
immutable object.
*
- * SegmentWithOvershadowedStatus's {@link #compareTo} method considers only
the {@link SegmentId}
+ * DataSegmentWithOvershadowedStatus's {@link #compareTo} method considers
only the {@link SegmentId}
* of the DataSegment object.
*/
public class SegmentWithOvershadowedStatus implements
Comparable<SegmentWithOvershadowedStatus>
{
private final boolean overshadowed;
+ /**
+ * dataSegment is serialized "unwrapped", i.e. it's properties are included
as properties of
+ * enclosing class. If in future, if {@Code SegmentWithOvershadowedStatus}
were to extend {@link DataSegment},
Review comment:
Suggest adding a test that verifies that the serialized form generated with
the unwrapped annotation can be successfully deserialized as a subclass (can
make a test impl) of DataSegment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
