himanshug commented on a change in pull request #7588: multi-value string
column support for expressions
URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288730317
##########
File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
##########
@@ -23,13 +23,20 @@ expr : 'null' #
null
| expr ('<'|'<='|'>'|'>='|'=='|'!=') expr # logicalOpExpr
| expr ('&&'|'||') expr # logicalAndOrExpr
| '(' expr ')' # nestedExpr
+ | IDENTIFIER '(' lambda ',' fnArgs ')' # applyFunctionExpr
| IDENTIFIER '(' fnArgs? ')' # functionExpr
| IDENTIFIER # identifierExpr
| DOUBLE # doubleExpr
| LONG # longExpr
| STRING # string
+ | '[' DOUBLE (','? DOUBLE)* ']' # doubleArray
+ | '[' LONG (','? LONG)* ']' # longArray
+ | '[' STRING (','? STRING)* ']' # stringArray
;
+lambda : (IDENTIFIER | '(' IDENTIFIER (','? IDENTIFIER)* ')') '->' expr
Review comment:
also, I don't think this allows lambda expressions with no arguments which
you might wanna allow and also I think the code later assumes that no arg
lambdas are allowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
