himanshug commented on a change in pull request #7588: multi-value string
column support for expressions
URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288723761
##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -118,11 +182,41 @@ public ExprEval eval(ObjectBinding bindings)
}
}
+class LongArrayExpr extends ConstantArrayExpr
+{
+ private final Long[] value;
+
+ LongArrayExpr(Long[] value)
+ {
+ this.value = Preconditions.checkNotNull(value, "value");
+ }
+
+ @Nonnull
+ @Override
+ public Object getLiteralValue()
+ {
+ return value;
+ }
+
+ @Override
+ public String toString()
+ {
+ return
Arrays.stream(value).map(String::valueOf).collect(Collectors.joining(", "));
Review comment:
```suggestion
return Arrays.toString(value);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
