himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288731396
########## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ########## @@ -213,7 +435,7 @@ public void visit(Visitor visitor) final String name; final List<Expr> args; - public FunctionExpr(Function function, String name, List<Expr> args) + FunctionExpr(Function function, String name, List<Expr> args) Review comment: nit: not sure if, in Druid, we generally try to do access control at package level... I think we just let them be private/public/protected as needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
