Fokko commented on a change in pull request #7772: Bump Apache Avro to 1.9.0
URL: https://github.com/apache/incubator-druid/pull/7772#discussion_r294250897
 
 

 ##########
 File path: extensions-core/avro-extensions/pom.xml
 ##########
 @@ -57,30 +57,13 @@
           <groupId>org.slf4j</groupId>
           <artifactId>slf4j-api</artifactId>
         </exclusion>
-        <exclusion>
-          <groupId>org.codehaus.jackson</groupId>
-          <artifactId>jackson-core-asl</artifactId>
-        </exclusion>
-        <exclusion>
-          <groupId>org.codehaus.jackson</groupId>
-          <artifactId>jackson-mapper-asl</artifactId>
-        </exclusion>
 
 Review comment:
   Yes, it moved from Jackson 1.x `org.codehaus.jackson` to 2.x 
`com.fasterxml.jackson`. If this is a problem, it depends. I think for Druid 
itself it will pan out, but in combination with different Hadoop versions, as 
always, there might be issues.
   
   I also have a PR to bump Druid to the same version: 
https://github.com/apache/incubator-druid/pull/7701.  As you can see there are 
no breaking API changes, so I don't expect a lot of issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to