sashidhar edited a comment on issue #7875: Make required S3 permissions consistent for pushing segments and task logs URL: https://github.com/apache/incubator-druid/issues/7875#issuecomment-502643909 @dclim Please look at my questions and comments at https://github.com/apache/incubator-druid/pull/7907/files. Other questions: 1. I was unable to find a test class corresponding to S3TaskLogs.java. Can you please point me to the corresponding test class ? 2. I haven't covered the fallback you mentioned in the PR I've raised yet.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
