leventov commented on a change in pull request #7838: Improve IncrementalIndex
concurrency scalability
URL: https://github.com/apache/incubator-druid/pull/7838#discussion_r295932100
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -1040,12 +1032,41 @@ public DateTime getMaxIngestedEventTime()
return maxIngestedEventTime.get();
}
- private static class DimensionData
+ private static class RowDimsKeyComponents
{
- private Map<String, ColumnCapabilitiesImpl> columnCapabilities;
- private Map<String, DimensionDesc> dimensionDescs;
- private List<DimensionDesc> dimensionDescsList;
+ public Map<String, Object> getRowDimKeys()
+ {
+ return rowDimKeys;
+ }
+
+ @Nullable
+ public DimensionData getUpdatedDimensionData()
+ {
+ return updatedDimensionData;
+ }
+
+ public List<String> getParseExceptionMessages()
+ {
+ return parseExceptionMessages;
+ }
+ private final Map<String, Object> rowDimKeys;
Review comment:
Put fields above methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
