leventov commented on a change in pull request #7838: Improve IncrementalIndex
concurrency scalability
URL: https://github.com/apache/incubator-druid/pull/7838#discussion_r294321718
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -1154,22 +1220,23 @@ protected ColumnSelectorFactory
makeColumnSelectorFactory(
protected final Comparator<IncrementalIndexRow> dimsComparator()
{
- return new IncrementalIndexRowComparator(dimensionDescsList);
Review comment:
For context, here is an explanation of this kind of bug, including
specifically in application to ArrayList:
https://github.com/code-review-checklists/java-concurrency#unsafe-concurrent-point-read
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
