sashidhar commented on issue #7858: Turn ImmutableDruidDataSource into a data 
container
URL: 
https://github.com/apache/incubator-druid/issues/7858#issuecomment-504772098
 
 
   Earlier,
   
   `Assert.assertEquals(
           
listDataSources.stream().map(DruidDataSource::toImmutableDruidDataSource).collect(Collectors.toSet()),
           new HashSet<>(result)
   );`
   
   Test: 
https://github.com/apache/incubator-druid/blob/master/server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java
   
   Collecting the stream as a list instead of a set.
   
   `    TestUtils.assertEqualsImmutableDruidDataSource(
           
listDataSources.stream().map(DruidDataSource::toImmutableDruidDataSource).collect(Collectors.toList()),
           new ArrayList<>(result)
       );`
   
   Let me know if this is right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to