jihoonson commented on a change in pull request #7933: #7858 Throwing
UnsupportedOperationException from ImmutableDruidDataSource's equals() and
hashCode() methods
URL: https://github.com/apache/incubator-druid/pull/7933#discussion_r297339185
##########
File path:
server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java
##########
@@ -268,11 +268,11 @@ public Access authorize(AuthenticationResult
authenticationResult1, Resource res
Assert.assertEquals(200, response.getStatus());
Assert.assertEquals(1, result.size());
- Assert.assertEquals(
+ TestUtils.assertEqualsImmutableDruidDataSource(
listDataSources.subList(0, 1).stream()
.map(DruidDataSource::toImmutableDruidDataSource)
- .collect(Collectors.toSet()),
- new HashSet<>(result)
+ .collect(Collectors.toList()),
Review comment:
Same here. They should be sorted first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
