jihoonson commented on a change in pull request #7933: #7858 Throwing UnsupportedOperationException from ImmutableDruidDataSource's equals() and hashCode() methods URL: https://github.com/apache/incubator-druid/pull/7933#discussion_r297342280
########## File path: server/src/test/java/org/apache/druid/test/utils/TestUtils.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.test.utils; + +import org.apache.druid.client.ImmutableDruidDataSource; +import org.junit.Assert; + +import java.util.ArrayList; +import java.util.List; + +public class TestUtils +{ + + /** + * This method is to check equality of {@link ImmutableDruidDataSource} objects to be called from test code. + * @param expected expected object + * @param actual actual object + * + */ + public static void assertEqualsImmutableDruidDataSource(Object expected, Object actual) + { + if (equalsRegardingNull(expected, actual)) { + return; + } else { + throw new AssertionError("Expected and actual objects differ."); + } + } + + private static boolean equalsRegardingNull(Object expected, Object actual) + { + if (expected == null) { + return actual == null; + } + + if (expected instanceof ArrayList<?> && actual instanceof ArrayList<?>) { Review comment: Why should this method be able to compare `ArrayList` as well as `ImmutableDruidDataSource`? I suggest to add two methods to compare each type. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
