jon-wei commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r295017263
##########
File path:
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java
##########
@@ -103,8 +105,9 @@
SegmentIdWithShardSpec allocatePendingSegment(
String dataSource,
String sequenceName,
- String previousSegmentId,
+ @Nullable String previousSegmentId,
Interval interval,
+ ShardSpecFactory shardSpecFactory,
Review comment:
Can you update the javadoc with the new parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
