jon-wei commented on a change in pull request #7547: Add support minor 
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r297416388
 
 

 ##########
 File path: 
core/src/main/java/org/apache/druid/timeline/partition/NumberedOverwritingShardSpecFactory.java
 ##########
 @@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.timeline.partition;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import javax.annotation.Nullable;
+
+public class NumberedOverwritingShardSpecFactory implements ShardSpecFactory
+{
+  private final int startRootPartitionId;
+  private final int endRootPartitionId;
+  private final short minorVersion;
+
+  @JsonCreator
+  public NumberedOverwritingShardSpecFactory(
+      @JsonProperty("startRootPartitionId") int startRootPartitionId,
+      @JsonProperty("endRootPartitionId") int endRootPartitionId,
+      @JsonProperty("minorVersion") short minorVersion
+  )
+  {
+    this.startRootPartitionId = startRootPartitionId;
+    this.endRootPartitionId = endRootPartitionId;
+    this.minorVersion = minorVersion;
+  }
+
+  @JsonProperty
+  public int getStartRootPartitionId()
+  {
+    return startRootPartitionId;
+  }
+
+  @JsonProperty
+  public int getEndRootPartitionId()
+  {
+    return endRootPartitionId;
+  }
+
+  @JsonProperty
+  public short getMinorVersion()
+  {
+    return minorVersion;
+  }
+
+  @Override
+  public ShardSpec create(ObjectMapper objectMapper, @Nullable ShardSpec 
specOfPreviousMaxPartitionId)
+  {
+    return new NumberedOverwriteShardSpec(
+        specOfPreviousMaxPartitionId == null
 
 Review comment:
   Since this is an overwrite shardspec, should getting a null 
`specOfPreviousMaxPartitionId` be an error condition? (Sounds like that would 
mean nothing is being overwritten?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to